Welcome, guest!

Feel free to read the blog, browse for themes, or join the club.

Suggestion for Hybrid Tabs

  1. some of our users have javascript off by default due too company rules...
    I would suggest to change tabs.css form display: none to

    .tab-content {
    	display: block;
    	}

    and add the following to the links <a ... of each tab:
    href="#choose_an_proper_name"
    and set the proper id for each tab - surprise :D
    id="#choose_an_proper_name"

    if my tests are right this would work for people without js or css (screen readers)

    Greetings

  2. You must be a logged-in exclusive member to view this reply.

  3. Yes thats right for the first part (but some of your child themes provide a tabs.css).

    But to change the links to work as anchor wold require to change the plugin as folows but it comes with a drawback - the anchors works too if javascript is enabled :/ thats why i decided to not use it at the moment - looking for a better soltuion ^^

    line 63 from:
    echo '<li class="t' . $i . ' t"><a class="t' . $i . '" title="' . $tab[1] . '">' . $tab[1] . '</a></li>';

    to:
    echo '<li class="t' . $i . ' t"><a href="#set-' . $tab_set_num . '-tab-' . $i . '" class="t' . $i . '" title="' . $tab[1] . '">' . $tab[1] . '</a></li>';

    and line 72 from:
    echo '<div class="tab-content t' . $j . '">';

    into
    echo '<div class="tab-content t' . $j . '" id="set-' . $tab_set_num . '-tab-' . $j . '" class="t' . $i . '">';

  4. Another option would be hiding the menu with css, and then displaying it with the javascript, as having the menu items with javascript disabled doesn't make that much sense.

  5. the point was to have them visible if javascript is diabled in browsers ... company rules etc...

  6. Agreed - but I also thing the tab menu isn't really useful if javascript is disabled (could be, depending on how you're using it, I suppose), so from that standpoint, you should probably have them invisible if javascript is disabled.

Reply

You must log in to post.

Limited Access

If you have an account, please take a moment to log in.

Non-exclusive members have limited access to the support forums.

To enjoy the full range of support, sign up for an exclusive membership in the theme club.

Support Forums

  • Bliss Theme (202 posts)
  • Hybrid Theme (17,127 posts)
  • Options Theme (10,322 posts)
  • Structure Theme (2,626 posts)
  • Visionary Theme (767 posts)
  • bbPress Themes (293 posts)
  • WordPress Plugins (1,619 posts)
  • General Discussion (4,016 posts)